Dependency: eliminate legacy openssl provider#87
Open
ivan-zynesis wants to merge 2 commits intobitcoinjs:masterfrom
Open
Dependency: eliminate legacy openssl provider#87ivan-zynesis wants to merge 2 commits intobitcoinjs:masterfrom
ivan-zynesis wants to merge 2 commits intobitcoinjs:masterfrom
Conversation
ivan-zynesis
force-pushed
the
remove-node16-openssl-dependencies
branch
from
281b3c8 to
fb30ef2
Compare
ivan-zynesis
force-pushed
the
remove-node16-openssl-dependencies
branch
from
fb30ef2 to
daaa87d
Compare
ivan-zynesis
changed the title
bs58check to v3
Author
|
Hi @junderw, any chance we can get this reviewed and iterate to be mergable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has been done
bs58checkdependency to v3 which changecreateHashimplementation to use@noble/hashes@noble/hashesWhy
Allow usage of this library in node v18 without requiring
--openssl-legacy-providerflag.